Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more logging to debug (bnc#994127) #425

Merged
merged 2 commits into from
Aug 24, 2016
Merged

Conversation

jreidinger
Copy link
Member

it do not deserve own changelog entry as it is just more debugging, so fine if it is send later to BS

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 32.75% when pulling 19b4ab3 on more_logging_in_proposal into 8f3ecaf on master.

@@ -261,6 +261,7 @@ def handle_skip

def pre_continue_handling
@skip = if Yast::UI.WidgetExists(Id(:skip))
log.info "there is skip widget with value #{Yast::UI.QueryWidget(Id(:skip), :Value)}."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: maybe a bit more DRYer (+ use inspect):

val = Yast::UI.QueryWidget(Id(:skip), :Value)
log.info "there is :skip widget with value #{val.inspect}"
val

@lslezak
Copy link
Member

lslezak commented Aug 24, 2016

LGTM

@jreidinger jreidinger merged commit 9065345 into master Aug 24, 2016
@jreidinger jreidinger deleted the more_logging_in_proposal branch August 24, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants