Move product selection to welcome #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
move-product-selection-to-welcome
branch
from
b16006c
to
f186cf0
Compare
imobachgs
force-pushed
the
move-product-selection-to-welcome
branch
from
f186cf0
to
9476f25
Compare
teclator
reviewed
Sep 1, 2017
| return nil | ||
| end | ||
| setup_final_choice | ||
| merge_and_run_workflow if selected_product |
There was a problem hiding this comment.
is this check really needed?
teclator
reviewed
Sep 1, 2017
| end | ||
| end | ||
|
|
||
| # Most of the work is done by #retranslate_yast. If changing to english if |
teclator
requested changes
Sep 1, 2017
teclator
reviewed
Sep 1, 2017
test/inst_complex_welcome_test.rb
Outdated
| @@ -48,6 +67,12 @@ | |||
|
|
|||
| describe "#main" do | |||
| let(:restarting) { false } | |||
There was a problem hiding this comment.
Please, remove also this from the test as it is not needed anymore
imobachgs
changed the title
* master: Adapt unit test due changes in module version + changelog Skip inst_complex_welcome in auto mode.
imobachgs
force-pushed
the
move-product-selection-to-welcome
branch
from
09db101
to
4115a53
Compare
|
Rubocop is still unhappy |
|
Yes, you are right. I did not check Travis because I expected a dependencies problem (new yast2-packager and yast2 are not available yet). Now Rubocop is happy but it is failing due to missing dependencies :) |
teclator
approved these changes
Sep 4, 2017
|
Thnx ;) it LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires yast/yast-yast2#619, yast/yast-packager#273 and
yast/yast-country#138.
Move product's selection to welcome screen.