Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge workflow and add support to disable buttons on CWM::Dialog #619

Merged
merged 4 commits into from
Sep 4, 2017

Conversation

imobachgs
Copy link
Contributor

This PR add support to:

  • Merge product's workflow (moving the logic from ProductSelector widget.
  • Extends CWM::Dialog to support disabling buttons.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 28.436% when pulling 92305cf on move-product-selection-to-welcome into 5a2d137 on master.


- Add support to disable buttons on CWM::Dialog
- Add a method WorkflowManager#merge_product_workflow which allows
to merge a product workflow (fate#322267)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing version number

Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 28.436% when pulling afbaf66 on move-product-selection-to-welcome into 5a2d137 on master.

@imobachgs imobachgs merged commit 6626bfb into master Sep 4, 2017
@imobachgs imobachgs deleted the move-product-selection-to-welcome branch March 7, 2018 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants