Add a NtpSetup installation dialog #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
force-pushed
the
feature/ntp-setup
branch
3 times, most recently
from
93dd007
to
40eb413
Compare
dgdavid
commented
Mar 29, 2019
| # | ||
| # @return [Array<String>] proposed NTP servers, empty if nothing suitable found | ||
| def ntp_servers | ||
| # TODO: use Yast::NtpClient.ntp_conf if configured |
There was a problem hiding this comment.
I do not understand this TODO comment. I mean, it is not clear to me if we can do what it is stated there or simply keep the current behavior and also de TODO comment.
@lslezak it seems that you wrote it originally. Any suggestion?
There was a problem hiding this comment.
IIRC that value is set in the time zone configuration (if you go to the details and configure the NTP server there), so there a small duplication.
For now I'd just move it without further changes.
There was a problem hiding this comment.
So, keep it as it is, right?
jreidinger
reviewed
Apr 1, 2019
jreidinger
reviewed
Apr 1, 2019
Based on / extracted from yast2-caasp > https://github.com/yast/yast-caasp/blob/28e3023ca1e58afb544a3e0d844435c0dfce8905/src/lib/y2caasp/widgets/ntp_server.rb
Based on / extracted form yast2-caasp * https://github.com/yast/yast-caasp/blob/28e3023ca1e58afb544a3e0d844435c0dfce8905/src/lib/y2caasp/clients/kubeadm_role_dialog.rb
dgdavid
force-pushed
the
feature/ntp-setup
branch
2 times, most recently
from
b158835
to
d79e249
Compare
Co-Authored-By: David Díaz González <dgonzalez@suse.de>
dgdavid
force-pushed
the
feature/ntp-setup
branch
from
d79e249
to
d4f91a4
Compare
jreidinger
approved these changes
Apr 3, 2019
|
✔️ Public Jenkins job #53 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The screen for configuring NTP, currently available at
yast2-caasp, should be able to be used for whatever role.Short description of the original problem.
Solution
Move the dialog to
yast2-installation.Testing
yast2-caaspScreenshots