Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed BuildRequires: yast2-ntp-client (causing dependency cycle) #794

Merged
merged 1 commit into from Apr 4, 2019
Merged

Removed BuildRequires: yast2-ntp-client (causing dependency cycle) #794

merged 1 commit into from Apr 4, 2019

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Apr 4, 2019

  • BuildRequires: yast2-ntp-client caused a dependency cycle and must be removed.
  • It was needed only for the unit tests, can be replaced by a stub module
  • The disadvantage is that RSpec then cannot verify if the mocked methods really exist, but there is probably no better and simple solution

@lslezak
Removed BuildRequires: yast2-ntp-client (causing dependency cycle)
09397de 
(related to the previous fix bsc#1129095)

- 4.2.2
@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.686% when pulling 09397de on build_deps into fe848cc on master.

dgdavid
dgdavid approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit ced2966 into master Apr 4, 2019
@lslezak lslezak deleted the build_deps branch April 4, 2019 11:16
@yast-bot
Copy link
Contributor

yast-bot commented Apr 4, 2019

✔️ Public Jenkins job #54 successfully finished
✔️ Created OBS submit request #691479

@dgdavid
Copy link
Member

dgdavid commented Apr 4, 2019

Related to #791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lslezak @coveralls @yast-bot @dgdavid