Save and restore properly the proposal vertical scroll #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgdavid
force-pushed
the
restore-vscroll-position
branch
from
05f8150
to
1c733b2
Compare
dgdavid
force-pushed
the
restore-vscroll-position
branch
3 times, most recently
from
5279270
to
81c1181
Compare
dgdavid
force-pushed
the
restore-vscroll-position
branch
from
81c1181
to
a1b2da0
Compare
|
Oops; one thing left to check: Does yast-installation require the libyui version that introduces this property? |
Yes, it does. There is a conflict with |
|
✔️ Public Jenkins job #77 successfully finished |
|
✔️ Internal Jenkins job #18 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The proposal installation summary back to the top after performing any change, not preserving the scroll.
Why?
The proposal summary, which is being held by a
RichTextwidget, is re-drawn after making a change. So, it's actually new content.The solution
To use the new
:VScrollValueproperty added to the libyui RichText widget as part of the YaST UI improvements. Taking into account that the content could be longer or shorter after each change, the solution is not completely perfect but it's perfect enough for most of the time.Test
Tested manually via driver update in both, Qt and ncurse.
Screencasts
Before (toggle)
After (toggle)