Schema change #115
Merged
Schema change #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
approved these changes
May 12, 2020
|
|
||
| kdump = | ||
| element kdump { | ||
| MAP, |
There was a problem hiding this comment.
Is the indentation OK? I would say that it is slightly different to the used for the general section.
There was a problem hiding this comment.
I worry this use old ycp indentation rule with 4 width and every second indent is tab, so it creates some fancy indentation. If you are fine, I can unify it to have 2 space everywhere
There was a problem hiding this comment.
Yes, I am fine with that. Thanks.
imobachgs
approved these changes
May 12, 2020
|
✔️ Public Jenkins job #19 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trello: https://trello.com/c/HkFkUQHj/1791-3-continue-with-new-xml-parser-xml-validation
depends on yast/yast-autoinstallation#598
Agreed to postpone for now that trang and jing travis validation to not delay even more new xml parser.
bsc: https://bugzilla.suse.com/show_bug.cgi?id=1170886