-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manipulate system LDAP configuration rather than application LDAP configuration #26
Conversation
package/yast2-ldap.spec
Outdated
@@ -17,7 +17,7 @@ | |||
|
|||
|
|||
Name: yast2-ldap | |||
Version: 3.1.14 | |||
Version: 3.1.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the version to 3.2.0, 3.2.x should be now used in master
.
@@ -27,7 +27,7 @@ | |||
.ldap_conf | |||
|
|||
`ag_ini( | |||
`IniAgent( "/etc/openldap/ldap.conf" , | |||
`IniAgent( "/etc/ldap.conf" , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with LDAP so I have some questions here:
- Is there any possible regression regarding changing the config file path?
- I mean what if a user has already changed something in the
/etc/openldap/ldap.conf
file? Will be that change lost? - Or might be there a conflict between the files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two ldap.conf
files have vastly different responsibilities.
In the context of yast, it was never correct to use openldap/ldap.conf
to begin with, because yast manipulates OS settings rather than application settings.
Existing changes that are already carried out by the user will stay in openldap/ldap.conf
. It is not necessary to migrate any content from one file to another.
user management, hence let the configuration agent manipulate in /etc/ldap.conf (system LDAP configuration) rather /etc/openldap/ldap.conf (application LDAP configuration). This resolves bsc#994456. Bump version to 3.2.0.
@HouzuoGuo it seems this PR is still valid, but the bug was agains SP2, so if we plan to fix it for SLE-12-PS2 then the branch target should be modified. In other case, please fix conflicts. |
greetings from Helsinki - i've just moved and busy like a bee! if you have a project schedule to meet please get in touch with Peter Varkoly. |
@petervarkoly could you take care of it? Almost a year has passed since the PR was created and no one complaining in the bug. If you are fine with the changes I can solve the conflicts and ask for review for moving forward with it |
I will close this PR by now, a new one can be created from it or feel free to reopen this one if do you plan to work on it. |
Because usages of Yast::Ldap operate in the context of system
user management, hence let the configuration agent manipulate in
/etc/ldap.conf (system LDAP configuration) rather
/etc/openldap/ldap.conf (application LDAP configuration).
This resolves bsc#994456.
Bump version to 3.1.15.