Skip to content

Commit

Permalink
Created own class in lib/ for dhcp autoconfiguration
Browse files Browse the repository at this point in the history
  • Loading branch information
@mchf
mchf committed Apr 24, 2014
1 parent 0a25454 commit 0cea678
Show file tree
Hide file tree
Showing 3 changed files with 169 additions and 154 deletions.
3 changes: 2 additions & 1 deletion src/Makefile.am
View file
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ ylibdir = @ylibdir@/network
ylib_DATA = \
lib/network/edit_nic_name.rb \
lib/network/confirm_virt_proposal.rb \
lib/network/install_inf_convertor.rb
lib/network/install_inf_convertor.rb \
lib/network/network_autoconfiguration.rb

EXTRA_DIST = \
$(module_DATA) \
Expand Down
156 changes: 3 additions & 153 deletions src/clients/inst_setup_dhcp.rb
View file
Original file line number Diff line number Diff line change
@@ -1,156 +1,6 @@
require "yast"
require "network/network_autoconfiguration"

#enclose client into own namespace to prevent messing global namespace
module SetupDHCPClient

include Yast

Yast.import "LanItems"
Yast.import "NetworkInterfaces"

Yast.include self, "network/routines.rb"

BASH_PATH = Path.new(".target.bash")

def self.network_cards
LanItems.Read
LanItems.GetNetcardNames
end

# Makes DHCP setup persistent
#
# instsys currently uses wicked as network services "manager" (including
# dhcp client). wicked is currently able to configure a card for dhcp leases
# only via loading config from file. All other ways are workarounds and
# needn't to work when wickedd* services are already running
def self.setup_dhcp card
index = LanItems.FindDeviceIndex(card)

if index == -1
raise "Failed to save configuration for device #{card}"
end

LanItems.current = index
LanItems.SetItem

#tricky part if ifcfg is not set
# yes, this code smell and show bad API of LanItems
if !LanItems.IsCurrentConfigured
NetworkInterfaces.Add
current = LanItems.Items[LanItems.current]
current["ifcfg"] = card
end

LanItems.bootproto = "dhcp"
LanItems.startmode = "auto"

LanItems.Commit
end

def self.reload_config(card)
SCR.Execute(BASH_PATH, "wicked ifreload '#{card}'") == 0
end

def self.delete_config(devname)
LanItems.delete_dev(devname)
end

def self.write_configuration
NetworkInterfaces.Write("")
end

def self.activate_changes(devnames)
return false if !write_configuration

# workaround for gh#yast/yast-core#74 (https://github.com/yast/yast-core/issues/74)
NetworkInterfaces.CleanCacheRead()

devnames.map { |d| reload_config(d) }
end

def self.configured?(devname)
# TODO:
# one day there should be LanItems.IsItemConfigured, but we currently
# miss index -> devname translation. As this LanItems internal structure
# will be subject of refactoring, we will use NetworkInterfaces directly.
# It currently doesn't hurt as it currently writes configuration for both
# wicked even sysconfig.
NetworkInterfaces.Check(devname)
end

# Checks if given device is active
#
# active device <=> a device which is reported as "up" by wicked
def self.active_config?(devname)
wicked_query = "wicked ifstatus --brief #{devname} | grep 'up$'"
SCR.Execute(BASH_PATH, wicked_query) == 0
end

# Returns list of servers used for internet reachability test
#
# Basicaly servers with product release notes should be used.
def self.target_servers
["scc.suse.com"]
end

# Check if given device can reach some of reference servers
def self.set_default_route_flag_if_wan_dev?(devname)
set_default_route_flag(devname, "yes")
activate_changes([devname])

reached = target_servers.any? do |server|
ping_cmd = "ping -I #{devname} -c 3 #{server}"
SCR.Execute(BASH_PATH, ping_cmd) == 0
end

log.info("Release notes can be reached via #{devname}: #{reached}")

if !reached
set_default_route_flag(devname, "no")
activate_changes([devname])
end

reached
end

# Sets sysconfig's DHCLIENT_SET_DEFAULT_ROUTE option for given device
#
# @param [String] devname name of device as seen by system (e.g. enp0s3)
# @param [String] value "yes" or "no", as in sysconfig
def self.set_default_route_flag(devname, value)
item_id = LanItems.FindDeviceIndex(devname)
LanItems.SetItemSysconfigOpt(item_id, "DHCLIENT_SET_DEFAULT_ROUTE", value)
end

include Logger

dhcp_cards = network_cards.select { |c| !configured?(c) && phy_connected?(c) }
log.info "Candidates for enabling DHCP: #{dhcp_cards}"

# TODO time consuming, some progress would be nice
dhcp_cards.each { |d| setup_dhcp(d) }

activate_changes(dhcp_cards)

# drop devices without dhcp lease
inactive_devices = dhcp_cards.select { |c| ! active_config?(c) }
log.info "Inactive devices: #{inactive_devices}"

inactive_devices.each { |c| delete_config(c) }

# setup route flag
active_devices = dhcp_cards - inactive_devices

if active_devices.size == 1
# just one dhcp device, nothing to care of
set_default_route_flag(active_devices.first, "yes")
else
# try to find just one dhcp aware device for allowing default route
# if there is more than one dhcp devices enabled for setting default
# route (DHCLIENT_SET_DEFAULT_ROUTE = "yes"). bnc#868187
active_devices.find { |d| set_default_route_flag_if_wan_dev?(d) }
end

activate_changes(dhcp_cards)
end
Yast::NetworkAutoconfiguration.instance.configure_dhcp

:next
164 changes: 164 additions & 0 deletions src/lib/network/network_autoconfiguration.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,164 @@
# encoding: utf-8

require "yast"

module Yast

# The class is responsible for generating / proposing automatic
# configuration during installation workflow
class NetworkAutoconfiguration
include Singleton
include Logger
include Yast

Yast.import "LanItems"
Yast.import "NetworkInterfaces"

BASH_PATH = Path.new(".target.bash")

def configure_dhcp
Yast.include self, "network/routines.rb"

dhcp_cards = network_cards.select { |c| !configured?(c) && phy_connected?(c) }
log.info "Candidates for enabling DHCP: #{dhcp_cards}"

# TODO time consuming, some progress would be nice
dhcp_cards.each { |d| setup_dhcp(d) }

activate_changes(dhcp_cards)

# drop devices without dhcp lease
inactive_devices = dhcp_cards.select { |c| ! active_config?(c) }
log.info "Inactive devices: #{inactive_devices}"

inactive_devices.each { |c| delete_config(c) }

# setup route flag
active_devices = dhcp_cards - inactive_devices

if active_devices.size == 1
# just one dhcp device, nothing to care of
set_default_route_flag(active_devices.first, "yes")
else
# try to find just one dhcp aware device for allowing default route
# if there is more than one dhcp devices enabled for setting default
# route (DHCLIENT_SET_DEFAULT_ROUTE = "yes"). bnc#868187
active_devices.find { |d| set_default_route_flag_if_wan_dev?(d) }
end

activate_changes(dhcp_cards)
end

private
def network_cards
LanItems.Read
LanItems.GetNetcardNames
end

# Makes DHCP setup persistent
#
# instsys currently uses wicked as network services "manager" (including
# dhcp client). wicked is currently able to configure a card for dhcp leases
# only via loading config from file. All other ways are workarounds and
# needn't to work when wickedd* services are already running
def setup_dhcp card
index = LanItems.FindDeviceIndex(card)

if index == -1
raise "Failed to save configuration for device #{card}"
end

LanItems.current = index
LanItems.SetItem

#tricky part if ifcfg is not set
# yes, this code smell and show bad API of LanItems
if !LanItems.IsCurrentConfigured
NetworkInterfaces.Add
current = LanItems.Items[LanItems.current]
current["ifcfg"] = card
end

LanItems.bootproto = "dhcp"
LanItems.startmode = "auto"

LanItems.Commit
end

def reload_config(card)
SCR.Execute(BASH_PATH, "wicked ifreload '#{card}'") == 0
end

def delete_config(devname)
LanItems.delete_dev(devname)
end

def write_configuration
NetworkInterfaces.Write("")
end

def activate_changes(devnames)
return false if !write_configuration

# workaround for gh#yast/yast-core#74 (https://github.com/yast/yast-core/issues/74)
NetworkInterfaces.CleanCacheRead()

devnames.map { |d| reload_config(d) }
end

def configured?(devname)
# TODO:
# one day there should be LanItems.IsItemConfigured, but we currently
# miss index -> devname translation. As this LanItems internal structure
# will be subject of refactoring, we will use NetworkInterfaces directly.
# It currently doesn't hurt as it currently writes configuration for both
# wicked even sysconfig.
NetworkInterfaces.Check(devname)
end

# Checks if given device is active
#
# active device <=> a device which is reported as "up" by wicked
def active_config?(devname)
wicked_query = "wicked ifstatus --brief #{devname} | grep 'up$'"
SCR.Execute(BASH_PATH, wicked_query) == 0
end

# Returns list of servers used for internet reachability test
#
# Basicaly servers with product release notes should be used.
def target_servers
["scc.suse.com"]
end

# Check if given device can reach some of reference servers
def set_default_route_flag_if_wan_dev?(devname)
set_default_route_flag(devname, "yes")
activate_changes([devname])

reached = target_servers.any? do |server|
ping_cmd = "ping -I #{devname} -c 3 #{server}"
SCR.Execute(BASH_PATH, ping_cmd) == 0
end

log.info("Release notes can be reached via #{devname}: #{reached}")

if !reached
set_default_route_flag(devname, "no")
activate_changes([devname])
end

reached
end

# Sets sysconfig's DHCLIENT_SET_DEFAULT_ROUTE option for given device
#
# @param [String] devname name of device as seen by system (e.g. enp0s3)
# @param [String] value "yes" or "no", as in sysconfig
def set_default_route_flag(devname, value)
item_id = LanItems.FindDeviceIndex(devname)
LanItems.SetItemSysconfigOpt(item_id, "DHCLIENT_SET_DEFAULT_ROUTE", value)
end

end
end

0 comments on commit 0cea678

Please sign in to comment.