Skip to content

Commit

Permalink
Another bunch of slaves released from comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mchf committed Jan 26, 2022
1 parent 28196fd commit 12d6901
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/lib/y2network/autoinst_profile/interface_section.rb
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def self.attributes
# @return [String] ???

# @!attribute bonding_slaveX
# @return [String] bonding slave on position X
# @return [String] bonding port on position X

# @!attribute bonding_module_opts
# @return [String] bonding options
Expand Down
2 changes: 1 addition & 1 deletion src/lib/y2network/boot_protocol.rb
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def static?
DHCP_AUTOIP = new("dhcp+autoip")
# zeroconf for ipv4
AUTOIP = new("autoip")
# do not assign properties. Usefull for bond slave or bridge port
# do not assign properties. Usefull for bond port or bridge port
NONE = new("none")
end
end
4 changes: 2 additions & 2 deletions src/lib/y2network/interface_config_builders/bonding.rb
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def interfaces

# Checks whether an interface can be included in particular bond interface
#
# @param iface [Interface] an interface to be validated as bond_iface slave
# @param iface [Interface] an interface to be validated as bond port
# TODO: Check for valid configurations. E.g. bond device over vlan
# is nonsense and is not supported by netconfig.
# Also devices included in a bridge should be excluded too.
Expand Down Expand Up @@ -123,7 +123,7 @@ def bondable?(iface)
# Convenience method to check whether the config of an interface is valid
# for including into a bond device
#
# @param iface [String] slave name to be validated
# @param iface [String] name of port to be validated
def valid_port_config?(iface)
conn = yast_config.connections.by_name(iface)

Expand Down
2 changes: 1 addition & 1 deletion src/lib/y2network/interface_config_builders/bridge.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def interfaces

# Checks whether an interface can be bridged in particular bridge
#
# @param iface [Interface] an interface to be validated as the bridge slave
# @param iface [Interface] an interface to be validated as the bridge port
def bridgeable?(iface)
# cannot report itself
return false if iface.name == @name
Expand Down
2 changes: 1 addition & 1 deletion src/lib/y2network/virtualization_config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def create
bridge_builder = bridge_builder_for(interface)

connection = config.connections.by_name(interface.name)
# The configuration of the connection being slaved is copied to the
# The configuration of the connection being included is copied to the
# bridge when exist
bridge_builder.configure_from(connection) if connection

Expand Down
6 changes: 3 additions & 3 deletions src/lib/y2network/widgets/bond_port.rb
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def handle(event)
def help
# TODO: write it
_(
"<p>Select the slave devices for the bond device.\n" \
"<p>Select a devices for including into the bond device.\n" \
"Only devices with the device activation set to <b>Never</b> " \
"and with <b>No Address Setup</b> are available.</p>"
)
Expand All @@ -89,7 +89,7 @@ def help
# Default function to init the value of port devices box for bonding.
def init
ports = @settings.ports
# TODO: use def items, but problem now is that slave_items returns term and not array
# TODO: use def items, but problem now is that port_items returns term and not array
items = slave_items_from(
@settings.bondable_interfaces.map(&:name),
ports,
Expand All @@ -114,7 +114,7 @@ def init
nil
end

# Default function to store the value of slave devices box.
# Default function to store the value of port devices box.
def store
@settings.ports = selected_items
end
Expand Down
4 changes: 2 additions & 2 deletions src/lib/y2network/widgets/bridge_ports.rb
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def help
""
end

# Default function to init the value of slave devices box for bridging.
# Default function to init the value of port devices box for bridging.
def init
br_ports = @settings.ports
items = slave_items_from(
Expand All @@ -59,7 +59,7 @@ def init
Yast::UI.ChangeWidget(Id(widget_id), :Items, items)
end

# Default function to store the value of slave devices box.
# Default function to store the value of port devices box.
def store
@settings.ports = value
end
Expand Down

0 comments on commit 12d6901

Please sign in to comment.