Do not change dev name in LanItemsClass#Items via reference. bnc#869776

Moreover LanItems.Items[key]["ifcfg"] can be immutable, so it could raise an exception.
yast · Mar 27, 2014 · 237a798 · 237a798
1 parent c3db27b
commit 237a798
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/modules/LanItems.rb b/src/modules/LanItems.rb
@@ -1285,7 +1285,7 @@ def BuildLanOverview
             IsEmpty(NetworkInterfaces.Current["WIRELESS_KEY_0"])
 
             # avoid colons
-            ifcfg_name.tr!(":", "/")
+            ifcfg_name = ifcfg_name.tr(":", "/")
             href = "lan--wifi-encryption-" + ifcfg_name
             # interface summary: WiFi without encryption
             warning = HTML.Colorize(_("Warning: no encryption is used."), "red")