Do not validate whether an interface name exists if not changed

yast · Sep 2, 2019 · 31e0f6c · 31e0f6c
1 parent 13567d3
commit 31e0f6c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/lib/y2network/widgets/interface_name.rb b/src/lib/y2network/widgets/interface_name.rb
@@ -30,6 +30,7 @@ def initialize(settings)
         textdomain "network"
 
         @settings = settings
+        @old_name = @settings.name
       end
 
       def label
@@ -57,7 +58,7 @@ def items
       end
 
       def validate
-        if @settings.name_exists?(value)
+        if @old_name != value && @settings.name_exists?(value)
           Yast::Popup.Error(
             format(_("Configuration name %s already exists.\nChoose a different one."), value)
           )

diff --git a/test/y2network/widgets/interface_name_test.rb b/test/y2network/widgets/interface_name_test.rb
@@ -32,7 +32,7 @@
   include_examples "CWM::ComboBox"
 
   describe "#validate" do
-    let(:valid_name) { "eth0" }
+    let(:valid_name) { "eth1" }
     let(:long_name) { "verylongcustomnicname123" }
 
     it "passes for valid names only" do
@@ -52,7 +52,7 @@
       expect(subject.validate).to be false
     end
 
-    it "fails for already used names" do
+    it "fails for already used names if changed" do
       allow(subject).to receive(:value).and_return valid_name
       allow(Yast::NetworkInterfaces).to receive(:List).and_return [valid_name]