Documentation and minor improvements.

yast · Jul 13, 2017 · 57fafb2 · 57fafb2
1 parent f8b07c7
commit 57fafb2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/package/yast2-network.changes b/package/yast2-network.changes
@@ -2,7 +2,7 @@
 Wed Jul 12 05:37:30 UTC 2017 - mfilka@suse.com
 
 - bnc#1038717
-  - avoid creating duplicit udev rules in AutoYaST installation
+  - avoid creating duplicate udev rules in AutoYaST installation
 - 3.1.178
 
 -------------------------------------------------------------------

diff --git a/src/lib/network/network_autoyast.rb b/src/lib/network/network_autoyast.rb
@@ -227,8 +227,15 @@ def valid_rename_udev_rule?(rule)
       true
     end
 
+    # Renames a network device represented by given item.
+    #
+    # @param [Integer] item is an item id. See LanItems for detail
+    # @param [String] name_to new device name
+    # @param [String] attr an udev attribute usable in NIC's rule. Currently just
+    #  "KERNELS" or "ATTR{address}" makes sense. This parameter is optional
+    # @param [String] value for the given udev attribute. Optional parameter.
     def rename_lan_item(item, name_to, attr = nil, key = nil)
-      return if item.nil? || item.empty? || item < 0 || item >= LanItems.Items.size
+      return if item.nil? || item < 0 || item >= LanItems.Items.size
       return if name_to.nil? || name_to.empty?
 
       # selecting according device name is unreliable (selects only in between configured devices)