fix appending hostname in Host#Update

yast · Oct 14, 2016 · 72281b1 · 72281b1
1 parent 8eb9bfa
commit 72281b1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/modules/Host.rb b/src/modules/Host.rb
@@ -249,7 +249,7 @@ def Update(oldhn, newhn, ip)
       if hosts.empty?
         @hosts.add_entry(ip, newhn, nick)
       else
-        canonical, *aliases = hosts.last
+        canonical, *aliases = hosts.last.split(" ")
         aliases << newhn
         aliases.concat(nick)
         @hosts.set_entry(ip, canonical, aliases)

diff --git a/test/host_test.rb b/test/host_test.rb
@@ -179,5 +179,15 @@
       expect(content.lines).to include("10.100.128.72   pepa pepa2\n")
       expect(content.lines).to include("10.0.0.42\tnewname.suse.cz newname\n")
     end
+
+    it "adds hostname as alias if ip have already its entry" do
+      Yast::Host.Read
+      Yast::Host.Update("pepa.labs.suse.cz", "newname.suse.cz", "10.100.128.72")
+      Yast::Host.Write
+
+      content = file.content
+
+      expect(content.lines).to include("10.100.128.72   pepa pepa2 newname.suse.cz newname\n")
+    end
   end
 end