Updates from code review

yast · Apr 2, 2020 · 83994b9 · 83994b9
1 parent c883a35
commit 83994b9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/src/lib/y2network/autoinst/s390_devices_reader.rb b/src/lib/y2network/autoinst/s390_devices_reader.rb
@@ -86,6 +86,7 @@ def load_lcs(config, device_section)
 
       # Returns the list of channel IDs from a string
       #
+      # @param ids [String] String representing the channel IDs
       # @return [Array<String>]
       def chanids_from(ids)
         ids.to_s.split(CHANIDS_SEPARATOR)

diff --git a/src/lib/y2network/autoinst_profile/s390_device_section.rb b/src/lib/y2network/autoinst_profile/s390_device_section.rb
@@ -117,6 +117,7 @@ def init_from_hashes(hash)
       #
       # It replaces spaces with colons.
       #
+      # @param ids [String] String representing the channel IDs
       # @return [String]
       def normalized_chanids(ids)
         ids.gsub(/\ +/, ":")

diff --git a/test/y2network/autoinst_profile/s390_device_section_test.rb b/test/y2network/autoinst_profile/s390_device_section_test.rb
@@ -59,7 +59,7 @@
       }
     end
 
-    it "loads properly boot protocol" do
+    it "loads properly type, chanids and boot protocol" do
       section = described_class.new_from_hashes(hash)
       expect(section.type).to eq "ctc"
       expect(section.chanids).to eq("0.0.0800:0.0.0801")
@@ -75,7 +75,7 @@
         }
       end
 
-      it "loads properly boot protocol" do
+      it "loads properly the chanids" do
         section = described_class.new_from_hashes(hash)
         expect(section.chanids).to eq("0.0.0800:0.0.0801")
       end