Fixed unit test

src/lib/y2network/presenters/interface_summary.rb

@@ -102,18 +102,20 @@ def text
           if hardware&.name && !hardware.name.empty?
             dev_name = _("Device Name: %s") % hardware.name
             rich << Yast::HTML.Bold(dev_name) << "<br>"
-
           end
 
-          if interface.firmware_configured?
-            rich << "<p><b>" << _("The device is configured by: ") << "</b>"
-            rich << interface.firmware_configured_by.to_s << "</p>"
-          else
+          unless interface.firmware_configured?
             rich << "<p>"
             rich << _("The device is not configured. Press <b>Edit</b>\nto configure.\n")
             rich << "</p>"
           end
         end
+
+        if interface.firmware_configured?
+          rich << "<p><b>" << _("The device is configured by: ") << "</b>"
+          rich << interface.firmware_configured_by.to_s << "</p>"
+        end
+
         rich
       end
 

test/y2network/presenters/interface_summary_test.rb

@@ -40,9 +40,11 @@
   let(:interfaces) do
     Y2Network::InterfacesCollection.new(
       [
-        double(Y2Network::Interface, hardware: nil, name: "vlan1"),
-        double(Y2Network::Interface, hardware: double.as_null_object, name: "eth1"),
-        double(Y2Network::Interface, hardware: double.as_null_object, name: "eth0")
+        double(Y2Network::Interface, hardware: nil, name: "vlan1", firmware_configured?: false),
+        double(Y2Network::Interface, hardware: double.as_null_object, name: "eth1",
+          firmware_configured?: false),
+        double(Y2Network::Interface, hardware: double.as_null_object, name: "eth0",
+          firmware_configured?: false)
       ]
     )
   end
@@ -75,7 +77,7 @@
   describe "#text" do
     it "returns a summary in text form" do
       text = presenter.text
-      expect(text).to be_a(::String)
+      expect(text).to be_a(String)
     end
 
     context "when a remote IP address is configured" do

test/y2network/wicked/interfaces_reader_test.rb

@@ -104,7 +104,7 @@
     it "reads interfaces configuration"
 
     context "when the interface is configured by hardware" do
-      let(:firmware_interfaces ) { { :ibft => ["eth0"] } }
+      let(:firmware_interfaces) { { ibft: ["eth0"] } }
 
       before do
         allow(reader).to receive(:firmware_interfaces_by_extension).and_return(firmware_interfaces)

test/y2network/widgets/interfaces_table_test.rb

@@ -31,10 +31,13 @@
   let(:description) { double(:value= => nil) }
 
   let(:eth0) do
-    instance_double(Y2Network::Interface, name: "eth0", hardware: hwinfo, old_name: "eth1")
+    instance_double(Y2Network::Interface, name: "eth0", hardware: hwinfo, old_name: "eth1",
+      firmware_configured_by: nil, firmware_configured?: false)
   end
+
   let(:br0) do
-    instance_double(Y2Network::VirtualInterface, name: "br0", hardware: nil, old_name: nil)
+    instance_double(Y2Network::VirtualInterface, name: "br0", hardware: nil, old_name: nil,
+      firmware_configured_by: nil, firmware_configured?: false)
   end
   let(:interfaces) { Y2Network::InterfacesCollection.new([eth0, br0]) }
   let(:hwinfo) do
@@ -179,5 +182,17 @@
         subject.handle
       end
     end
+
+    context "when the device is configured by hardware" do
+      let(:eth0) do
+        instance_double(Y2Network::Interface, name: "eth0", hardware: hwinfo, old_name: "eth1",
+          firmware_configured_by: :redfish, firmware_configured?: true)
+      end
+
+      it "shows which firmware extension configured the device in the description" do
+        expect(description).to receive(:value=).with(/configured by: <\/b>redfish/)
+        subject.handle
+      end
+    end
   end
 end