Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.com>
  • Loading branch information
imobachgs and teclator committed Feb 25, 2021
1 parent c1a1874 commit dd608cf
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/lib/y2network/wireless_cell.rb
Expand Up @@ -31,11 +31,11 @@ class WirelessCell
# @!attribute [r] channel
# @return [Integer] Wireless channel
# @!attribute [r] rates
# @return [Array<Bitrate>] Wireles rates
# @return [Array<Bitrate>] Wireless rates
# @!attribute [r] quality
# @return [Integer] Signal quality
# @!attribute [r] auth_mode
# @return [Array<String>] Security mechanisms
# @return [WirelessAuthMode] Security mechanisms
attr_reader :address, :essid, :mode, :channel, :rates, :quality, :auth_mode

# rubocop:disable Metrics/ParameterLists
Expand Down
2 changes: 1 addition & 1 deletion test/y2network/wireless_auth_mode_test.rb
Expand Up @@ -37,7 +37,7 @@
.to eq(Y2Network::WirelessAuthMode::NONE)
end

it "returns nil if the given name not found" do
it "returns nil if the given name is not found" do
expect(described_class.from_short_name("dummy")).to eq nil
end
end
Expand Down
2 changes: 1 addition & 1 deletion test/y2network/wireless_network_test.rb
Expand Up @@ -73,7 +73,7 @@
)
end

it "memoizes the the results" do
it "memoizes the results" do
described_class.all("wlo1")
expect(Y2Network::WirelessScanner).to_not receive(:new)
expect(described_class.all("wlo1", cache: true))
Expand Down

0 comments on commit dd608cf

Please sign in to comment.