another round of review fixes

yast · Sep 2, 2019 · df4bfcf · df4bfcf
1 parent 80bdcba
commit df4bfcf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/lib/y2network/connection_config/base.rb b/src/lib/y2network/connection_config/base.rb
@@ -64,8 +64,8 @@ def initialize
       end
 
       # Propose reasonable defaults for given config. Useful for newly created devices.
-      # @note difference between constructor and propose is that initialize should set defaults same as backend
-      #   and propose can have more tricky config or different to backend defaults.
+      # @note difference between constructor and propose is that initialize should set simple defaults
+      #   and propose have more tricky config that depends on env, product, etc.
       def propose
         propose_startmode
       end

diff --git a/src/lib/y2network/connection_config/wireless.rb b/src/lib/y2network/connection_config/wireless.rb
@@ -76,6 +76,7 @@ class Wireless < Base
 
     def initialize
       super
+
       self.mode = "Managed"
       self.essid = ""
       self.nwid = ""
@@ -87,10 +88,6 @@ def initialize
       self.eap_mode = "PEAP"
       self.eap_auth = "MSCHAPV2"
       self.ap_scanmode = 1
-    end
-
-    def propose
-      super
       # For WIFI DHCP makes more sense as majority of wifi routers act as dhcp servers
       self.bootproto = BootProtocol::DHCP
     end