Improve Y2Network::Route to/interface handling in the constructor

yast · Mar 21, 2019 · e13910c · e13910c
1 parent 1ace623
commit e13910c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/lib/y2network/route.rb b/src/lib/y2network/route.rb
@@ -28,7 +28,7 @@ class Route
     # @return [IPAddr,nil]
     attr_reader :gateway
 
-    def initialize(to, interface, gateway: nil, source: nil, preference: nil)
+    def initialize(to: :default, interface: :any, gateway: nil, source: nil, preference: nil)
       @to = to
       @interface = interface
       @gateway = gateway
@@ -40,7 +40,7 @@ def initialize(to, interface, gateway: nil, source: nil, preference: nil)
     #
     # @return [Boolean]
     def default?
-      @to.nil?
+      to == :default
     end
   end
 end
diff --git a/test/y2network/route_test.rb b/test/y2network/route_test.rb
@@ -24,15 +24,15 @@
 
 describe Y2Network::Route do
   subject(:route) do
-    described_class.new(to, interface)
+    described_class.new(to: to, interface: interface)
   end
 
   let(:to) { IPAddr.new("192.168.122.1") }
   let(:interface) { Y2Network::Interface.new("eth0") }
 
   describe "#default?" do
     context "when it is the default route" do
-      let(:to) { nil }
+      let(:to) { :default }
 
       it "returns true" do
         expect(route.default?).to eq(true)