Merge pull request #591 from teclator/fix_firewall_write

Removed unnecesary SuSEFirewall.Write (bnc#1066982)
yast · Nov 23, 2017 · ec72b69 · ec72b69
2 parents ea6ad70 + 83c4946
commit ec72b69
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/package/yast2-network.changes b/package/yast2-network.changes
@@ -1,3 +1,11 @@
+-------------------------------------------------------------------
+Wed Nov 15 19:22:41 UTC 2017 - knut.anderssen@suse.com
+
+- bnc#1066982
+  - Removed an unnecesary SuSEFirewall.Write call when storing the
+    Firewall remote client configuration.
+- 3.1.184
+
 -------------------------------------------------------------------
 Tue Nov 14 17:05:47 UTC 2017 - jreidinger@suse.com
 

diff --git a/package/yast2-network.spec b/package/yast2-network.spec
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-network
-Version:        3.1.183
+Version:        3.1.184
 Release:        0
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-build

diff --git a/src/include/network/remote/dialogs.rb b/src/include/network/remote/dialogs.rb
@@ -159,8 +159,6 @@ def RemoteMainDialog
       end
       if ret == :next
         CWMFirewallInterfaces.OpenFirewallStore(firewall_widget, "", event)
-        # OpenFirewallStore just sets variables, but we need real firewall write
-        SuSEFirewall.Write
 
         allow_with_vncmanager = UI.QueryWidget(Id(:allow_with_vncmanager), :Value)
         allow_without_vncmanager = UI.QueryWidget(Id(:allow_without_vncmanager), :Value)