NetworkAutoconfiguration#setup_dchp: Ensure network configuration is read before dealing with it #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
changed the title
teclator
changed the title
teclator
changed the title
|
✔️ Public Jenkins job #100 successfully finished |
|
✔️ Internal Jenkins job #30 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While the installation dhcp setup client do more checks and configuration, the firstboot client calls directly the
Yast::NetworkAutoconfiguration.instace.setup_dhcpmethod (see) which has been modified recently (#997).We basically moved the read of the configuration to another method.
https://github.com/yast/yast-network/pull/997/files#diff-fd690548c8d9ccc25675e4b0e82a0b49L52
Solution
Just add back the read of the configuration ensuring it has been read before checking it.