Fixed the proposal of the virtualization configuration #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchf
reviewed
Dec 16, 2019
mchf
reviewed
Dec 16, 2019
teclator
force-pushed
the
fix_bridge_virtualization_config
branch
from
d358663
to
9826752
Compare
mchf
reviewed
Dec 18, 2019
mchf
reviewed
Dec 18, 2019
teclator
force-pushed
the
fix_bridge_virtualization_config
branch
from
fefdd4f
to
8c31a9a
Compare
mchf
reviewed
Dec 20, 2019
teclator
force-pushed
the
fix_bridge_virtualization_config
branch
from
8c31a9a
to
a8bcaa9
Compare
|
✔️ Public Jenkins job #111 successfully finished |
|
✔️ Internal Jenkins job #42 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With network-ng, a regression was introduced in the network virtualization proposal.
That is, if for example there is only one interface configured by dhcp , it is skipped as bridge port candidate because it is already configured (of course same happen with any configured interface):
https://github.com/yast/yast-network/blob/master/src/modules/Lan.rb#L752
Introduced by:
4e0a75e#diff-a44342e8d97412ca7486bd2d61e8e429L864
The configuration of the interface should be copied to the bridge and it should be added as a bridge port as it was in the past.
The issue was detected as consequence of these bugs, which has been closed as the crash should not happen with last changes in network-ng but will face the described regression:
https://trello.com/c/Dh9D0SIi/1443-sles15-sp2-p2-1156986-yast-does-not-propose-configured-interfaces-for-virtualization-bridges
Solution
The configuration is created again and the logic has been moved to its own class.
Tests