Avoid crash if failed to resolve the IP from install.inf (bsc#1161217) #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was testing a method that was mocked, changed for a more reasonable test that probably honors the original intention.
|
✔️ Internal Jenkins job #56 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If install.inf contains an IP in the "hostname" field, YaST tries to resolve that to get a valid hostname. But there was a bug and if that resolution was not possible, YaST was crashing.
See https://bugzilla.suse.com/show_bug.cgi?id=1161217
There was a test to verify the correct behavior... but the test was as broken as the code.
In addition, I detected a dummy test that was testing the behavior of a fully mocked method. In the first two commits of this pull request, I tried to turn that into a reasonable test that, hopefully, fits the original intention of the test.