Using SysctlConfig class instead of Sysctl class #1041
Conversation
…ies (bsc#1151649).
schubi2
changed the title
Would be nice to have a link to the trello card as well as links to related pull requests, like for example the one yast/yast-yast2#1021 which added SysctlConfig class and the reason of the dependency version update. Using the storage-ng PR template is recommended: https://github.com/yast/yast-storage-ng/blob/master/.github/pull_request_template.md |
| sysctl_config.forward_ipv6 = routing.forward_ipv6 | ||
| sysctl_config.save unless sysctl_config.conflict? | ||
|
|
||
| update_ip_forwarding((sysctl_config.forward_ipv4 ? "1" : "0"), |
There was a problem hiding this comment.
Why were modified the calls to raw_forward_ methods ? are them not valid anymore?
There was a problem hiding this comment.
Imo has wished to remove them in the new class. :-)
There was a problem hiding this comment.
Ok, then next time we touch the class we should also get rid of of this documentation that is out of date or never implemented for this new class 😜
https://github.com/yast/yast-yast2/pull/1021/files#diff-4216cbac8e98ed10343a00513e10e917R47
|
❌ Public Jenkins job #133 failed |
Problem
Sysctl entries are stored in different files in different directories:
/run/sysctl.d,
/etc/sysctl.d
/usr/local/lib/sysctl.d
/usr/lib/sysctl.d
/lib/sysctl.d
/etc/sysctl.conf
General solution for it:
yast/yast-yast2#1021
Solution
Using SysctlConfig class.
Testing
Tested manually