Do not modify interface name when enslaving it (bsc#1165463)

[teclator]

Problem

When enslaving an interface with a physical port id it is renamed adding the description as the name.

• https://bugzilla.suse.com/show_bug.cgi?id=1165463

Solution

Use a dup of the interface name.

[lslezak]

LGTM

I'm just thinking if we could somehow avoid a similar bug in the future. Would something like interface.name.freeze work?

[coveralls]

Coverage remained the same at 70.009% when pulling dfaf520 on do_not_modify_slave_name into e65a94c on master.

[teclator]

LGTM

I'm just thinking if we could somehow avoid a similar bug in the future. Would something like interface.name.freeze work?

Well, the interface name can be modified when renaming. Thus, not sure about freezing it.

[lslezak]

I see, then OK.

[teclator]

LGTM

I'm just thinking if we could somehow avoid a similar bug in the future. Would something like interface.name.freeze work?

Thinking on it, I think that would be a good idea and at least we should do it in the constructor:

https://github.com/yast/yast-network/blob/master/src/lib/y2network/interface.rb#L77

And when renaming:

https://github.com/yast/yast-network/blob/master/src/lib/y2network/interface.rb#L112

But, will merge as it is by now if you are ok.

[yast-bot]

✔️ Internal Jenkins job #72 successfully finished
✔️ Created IBS submit request #212985