Force restart seems to not be needed anymore

[teclator]

Problem

openQA tests renaming a NIC and expects wicked to be restarted, which isn't

Before network-ng we set the force_restart flag when touching the udev rules for renaming an interface:

• https://github.com/yast/yast-network/blob/SLE-15-SP1/src/modules/LanItems.rb#L667

Or when proposing the bridge configuration for virtualization:

• https://github.com/yast/yast-network/blob/SLE-15-SP1/src/modules/Lan.rb#L922
• https://github.com/yast/yast-network/blob/SLE-15-SP1/src/modules/Lan.rb#L1084

But it is not set anymore, and thus, in case of renaming, the network is not restarted but just reloaded:

• https://github.com/yast/yast-network/blob/master/src/modules/Lan.rb#L864

It needs to be clarified if the current behavior is correct or the previous one should be brought back.

• https://trello.com/c/PJL0LoJC/1709-3-sle15-sp2-1165923-renaming-network-device-is-not-inducing-network-restart
• https://bugzilla.suse.com/show_bug.cgi?id=1165923

Solution

• After some discussion with the wicked team (@mtomaschewski @rtorrero), it seems that we can remove the force restart flag completely.

[coveralls]

Coverage decreased (-0.01%) to 70.375% when pulling 5f34741 on force_restart into 1c63b75 on master.

[jreidinger]

LGTM from my POV

[yast-bot]

✔️ Public Jenkins job #141 successfully finished
✔️ Created OBS submit request #787755

[yast-bot]

✔️ Internal Jenkins job #78 successfully finished