Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit to disable the virt bridge config proposal #1137

Merged
merged 5 commits into from
Feb 10, 2021

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Dec 24, 2020

Problem

The network bridge configuration is the default configuration of SLE or openSUSE when configured as a KVM or Xen hypervisor, and during an installation there is no way to disable the bridge configuration proposed by YaST.

This proposed configuration was in many cases transparent to the user and was somehow not noticed but since systemd MACAddressPolicy has changed and a bridge does not inherit the MAC address from its ports, it could be a problem to existent DHCP configurations based on mac addresses (see https://bugzilla.suse.com/show_bug.cgi?id=1136600)

Solution

  • By now, we would like to permit the user to disable the current bridge config proposal (in a common installation or in AutoYaST). The link will not be shown in the installation summary unless some of the virtualization packages is selected to be installed.

Creating a link to modify the bridge MACAddress policy as suggested in the bug is out of the scope of this PBI (see also the link example here https://github.com/systemd/systemd/pull/12792/files)

Screenshots

To be honest, I was not very creative, and use the same tests and links we have in the past which were remove by this commi (4cc0a6e)

ProposeBride
NotProposeBridge
ProposeBridgeNM

@coveralls
Copy link

coveralls commented Dec 24, 2020

Coverage Status

Coverage increased (+0.05%) to 78.673% when pulling 0f61776 on influence_bridge_proposal into e3ee822 on master.

@teclator teclator force-pushed the influence_bridge_proposal branch 2 times, most recently from e8f92f8 to 07e740b Compare February 9, 2021 18:06
@teclator teclator changed the title [RFC] Permit to disable the virt bridge config proposal Permit to disable the virt bridge config proposal Feb 10, 2021
@teclator teclator merged commit 08c6f1f into master Feb 10, 2021
@teclator teclator deleted the influence_bridge_proposal branch February 10, 2021 13:43
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #214 successfully finished
✔️ Created OBS submit request #870905

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #132 successfully finished
✔️ Created IBS submit request #235666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants