-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit to disable the virt bridge config proposal #1137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
force-pushed
the
influence_bridge_proposal
branch
from
December 24, 2020 12:46
17633ef
to
fb1f8dc
Compare
teclator
force-pushed
the
influence_bridge_proposal
branch
from
December 24, 2020 13:17
fb1f8dc
to
f5a452a
Compare
teclator
force-pushed
the
influence_bridge_proposal
branch
from
February 9, 2021 09:17
f5a452a
to
aa5aa83
Compare
teclator
force-pushed
the
influence_bridge_proposal
branch
2 times, most recently
from
February 9, 2021 18:06
e8f92f8
to
07e740b
Compare
lslezak
reviewed
Feb 9, 2021
teclator
force-pushed
the
influence_bridge_proposal
branch
from
February 10, 2021 07:31
07e740b
to
8c6c93b
Compare
teclator
changed the title
[RFC] Permit to disable the virt bridge config proposal
Permit to disable the virt bridge config proposal
Feb 10, 2021
imobachgs
approved these changes
Feb 10, 2021
✔️ Public Jenkins job #214 successfully finished |
✔️ Internal Jenkins job #132 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The network bridge configuration is the default configuration of SLE or openSUSE when configured as a KVM or Xen hypervisor, and during an installation there is no way to disable the bridge configuration proposed by YaST.
This proposed configuration was in many cases transparent to the user and was somehow not noticed but since systemd MACAddressPolicy has changed and a bridge does not inherit the MAC address from its ports, it could be a problem to existent DHCP configurations based on mac addresses (see https://bugzilla.suse.com/show_bug.cgi?id=1136600)
Solution
Creating a link to modify the bridge MACAddress policy as suggested in the bug is out of the scope of this PBI (see also the link example here https://github.com/systemd/systemd/pull/12792/files)
Screenshots
To be honest, I was not very creative, and use the same tests and links we have in the past which were remove by this commi (4cc0a6e)