Add a writer for NetworkManager #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
write-nm-configuration
branch
from
b65f471
to
0f483d2
Compare
* It just writes some basic information.
imobachgs
force-pushed
the
write-nm-configuration
branch
from
0f483d2
to
62fac51
Compare
|
✔️ Public Jenkins job #199 successfully finished |
|
✔️ Internal Jenkins job #117 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step toward being able to write the network configuration at installation time even if you are using NetworkManager (default option for openSUSE). It implements these changes:
Y2Network::ConfigWriter, including collaborators likeY2Network::Sysconfig::{DNSWriter,HostnameWriter,InterfacesWriter} which live know underY2Network::ConfigWriters`. Maybe we should improve the naming.InterfaceFileandRoutesFile) live now in theCFAmodule.Trello: https://trello.com/c/EdjoT1NN/2256-8-write-networkmanager-configuration-during-installation