Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save network manager config #1143

Merged
merged 4 commits into from Jan 20, 2021
Merged

Save network manager config #1143

merged 4 commits into from Jan 20, 2021

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jan 20, 2021 •
edited

Write NetworkManager configuration at the end of the installation process.

  • Live installer: just copy the files under /etc/NetworkManager/system-connections as it is already using NetworkManager.
  • Normal installation: use the new support for NetworkManager to write the configuration.

Manually tested the regular and the live installer.

Trello: https://trello.com/c/EdjoT1NN/

@coveralls
Copy link

coveralls commented Jan 20, 2021 •
edited

Coverage Status

Coverage increased (+0.04%) to 78.56% when pulling 0877487 on save-network-manager-config into a2f7ca5 on network-manager.

@imobachgs imobachgs changed the base branch from master to network-manager January 20, 2021 09:37
@imobachgs imobachgs marked this pull request as ready for review January 20, 2021 10:05
teclator
teclator approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit b3ee308 into network-manager Jan 20, 2021
@imobachgs imobachgs deleted the save-network-manager-config branch January 20, 2021 11:41
@teclator teclator mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teclator teclator teclator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imobachgs @coveralls @teclator