Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides always the layer2 argument when activating a qeth device #1188

Merged
merged 3 commits into from Mar 18, 2021

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Mar 17, 2021

Problem

There is a checkbox in the s390 qeth activation dialog in order to enable "layer2" support. When the checkbox is checked we add the layer2=1 argument to the activation call czhdev -e group_device_id, but in case of not checked we are using the auto-detection instead of giving the argument layer2=0 explicitly.

# chzdev qeth --help-attribute layer2
ATTRIBUTE layer2

  DESCRIPTION
    Control layer mode for a QETH device:
      0: Device works in layer 3 mode
      1: Device works in layer 2 mode
     -1: Driver attempts autodetection (read-only value)

  DEFAULT VALUE
    The default value is '-1'.

  ACCEPTED VALUES
    - Integers in the range -1 - 1

  NOTES
    - This attribute cannot be changed while the device is online

The auto-detection could be fine in z/VM but will not work on LPAR.

S390QethActivationDialog

Solution

Add always the argument layer2 with the option selected to the activation call.

Tests

  • Adapted unit test
  • Tested manually
y2network/s390_device_activator.rb(configure):80 Activating s390 device: 0.0.0700:0.0.0701:0.0.0702
lib/cheetah.rb(record_commands):160 Executing "/sbin/chzdev qeth 0.0.0700:0.0.0701:0.0.0702 -e layer2\=0".

@coveralls
Copy link

coveralls commented Mar 17, 2021

Coverage Status

Coverage increased (+0.009%) to 79.58% when pulling bfd8bca on qeth_layer2_always into 0ac388a on master.

@teclator teclator changed the title Provides always the layer2 argument when enabling a qeth device Provides always the layer2 argument when activating a qeth device Mar 18, 2021
@teclator teclator merged commit 127548f into master Mar 18, 2021
@teclator teclator deleted the qeth_layer2_always branch March 18, 2021 10:02
@teclator teclator restored the qeth_layer2_always branch March 18, 2021 10:02
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #233 successfully finished
✔️ Created OBS submit request #879859

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #149 successfully finished
✔️ Created IBS submit request #238179

teclator added a commit that referenced this pull request Mar 23, 2021
Provides always the layer2 argument when activating a qeth device
teclator added a commit that referenced this pull request Mar 23, 2021
Merge pull request #1188 from yast/qeth_layer2_always
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants