New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require to set a MAC address when L2 support is enabled #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
changed the title
Do not enforce to set a MAC address when L2 support is enabled
Do not require to set a MAC address when L2 support is enabled
Apr 12, 2021
teclator
force-pushed
the
l2_support_empty_mac
branch
from
April 12, 2021 18:53
dcd6ed2
to
17303df
Compare
@markkp could you take a look?, basically I have implemented what was suggested in https://bugzilla.suse.com/show_bug.cgi?id=1184474#c4 |
imobachgs
requested changes
Apr 13, 2021
imobachgs
approved these changes
Apr 13, 2021
imobachgs
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
imobachgs
approved these changes
Apr 14, 2021
✔️ Created IBS submit manually request #239390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is required to enter a valid MAC address when activating a qeth device with L2 support. This MAC in case of a zVM is usually assigned and specifying a different one is not authorized.
Solution
Screenshots