Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require to set a MAC address when L2 support is enabled #1201

Merged
merged 8 commits into from Apr 14, 2021

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Apr 12, 2021

Problem

It is required to enter a valid MAC address when activating a qeth device with L2 support. This MAC in case of a zVM is usually assigned and specifying a different one is not authorized.

S390QethActivation

Solution

  • Establishing a MAC address is not required anymore.
  • Request confirmation for storing the selected MAC address.

Screenshots

S390QethMACConfirmation
S390QethActivationHelpText

@coveralls
Copy link

coveralls commented Apr 12, 2021

Coverage Status

Coverage increased (+0.02%) to 79.634% when pulling 45a9ff7 on l2_support_empty_mac into 0602ce8 on SLE-15-SP3.

@teclator teclator changed the title Do not enforce to set a MAC address when L2 support is enabled Do not require to set a MAC address when L2 support is enabled Apr 12, 2021
@teclator
Copy link
Contributor Author

@markkp could you take a look?, basically I have implemented what was suggested in https://bugzilla.suse.com/show_bug.cgi?id=1184474#c4

src/lib/y2network/widgets/s390_common.rb Outdated Show resolved Hide resolved
test/y2network/widgets/s390_common_test.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/y2network/widgets/s390_common.rb Outdated Show resolved Hide resolved
@teclator teclator merged commit 9e0b033 into SLE-15-SP3 Apr 14, 2021
@teclator teclator deleted the l2_support_empty_mac branch April 14, 2021 08:45
@teclator
Copy link
Contributor Author

✔️ Created IBS submit manually request #239390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants