-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not crash when checking if an interface is a hotplug one (bsc#1184623) #1203
Conversation
src/include/network/lan/address.rb
Outdated
log.info "AddressDialog res: #{ret.inspect}" | ||
|
||
return ret if [:back, :abort].include?(ret) | ||
return ret if builder.interface&.hotplug? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could even return if !builder.boot_protocol.dhcp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good. I was just considering whether we could simplify it a little bit more...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. But perhaps @mchf has additional comments so, please, let's wait for him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
✔️ Public Jenkins job #243 successfully finished |
Problem
When we try to configure a virtual interface or an interface which is not present it does not have an interface associated and the hotplug check produces a crash.
Solution
Tests