bnc#754940 - missing help in hw dialog when adding new device. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code attempted to access a widget which was conditionally removed earlier.
The text is generated dynamically now. This is needed because the dialog can have different content. Depends on invocation (adding device or editing existing one). Standalone version of the dialog contains help text too.
|
|
||
| /* Manual network card setup help 2/4 */ | ||
| /* translators: do not translated udev, MAC, BusID*/ | ||
| _("<p><b>Udev Rules</b> are rules for the kernel device manager that allow | ||
| if( LanItems::operation == `add) |
There was a problem hiding this comment.
It might be nice to unify this check with isStandalone() function as it does the same check.
mvidner
added a commit
that referenced
this pull request
Aug 20, 2012
bnc#754940 - missing help in hw dialog when adding new device.
mchf
added a commit
that referenced
this pull request
Aug 20, 2012
A syntax fix + test case for a leftover in pull request #13. Comments resolved personally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code cleanup.