Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mvidner
commented
Nov 22, 2022
mvidner
commented
- https://bugzilla.opensuse.org/show_bug.cgi?id=1204871 "- [Staging] rubygem-rspec-* 3.12 breaks various yast modules build"
- see Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) yast-yast2#1279 for details
New rspec-mocks distinguish between hash and keyword arguments passed to `with`. The tested code does use hashes but we've used keywords in tests because it's shorter to write. Fixed. rspec-mocks 3.11.2 / 2022-10-25: > Bug Fixes: Support keyword argument semantics when constraining argument > expectations using with on Ruby 3.0+ with instance_double > rspec/rspec-mocks#1473 Why this took longer to fix? Misleading RSpec messages: Even with current rspec-mocks 3.12.0 the error message can be confusing, differing only in the object_id of the Path: Yast::SCR received :Write with unexpected arguments expected: (#<Yast::Path:0x00007f92c30a6f88 @components=["modules", "options", "virtio_net"]>, {"debug"=>"16"}) got: (#<Yast::Path:0x00007f92c30a4d00 @components=["modules", "options", "virtio_net"]>, {"debug"=>"16"}) That's because rspec/rspec-mocks@e931e81 only adds the distinguishing "(keyword arguments)" or "(options hash)" when the _inspect representations_ of the arguments are the same. To avoid this bug we could override #inspect to omit the #object_id whenever we override #==.
|
✔️ Internal Jenkins job #210 successfully finished |
|
✔️ Public Jenkins job #314 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.