Copy only the selected backend configuration to the target system (bsc#1206723)

[teclator]

Problem

Until now, the wicked or sysconfig network configuration was always copying to the target system during a normal installation.

Recent changes in the Basesystem filesystem packages removed the /etc/sysconfig/network hierarchy from it not being used by default anymore which raises an exception when YaST tries to merge the dhcp and config files from the instsys.

• https://trello.com/c/SEM7dN4G
• https://bugzilla.suse.com/show_bug.cgi?id=1206723

Solution

Copy only the configuration of the selected backend to the target system.

Testing

• Added a new unit test
• Tested manually a MicroOS installation with
  • https://build.opensuse.org/package/revisions/Base:System/filesystem (Revision 233)
  • https://build.opensuse.org/package/show/openSUSE:Factory/sysconfig (v0.0.90)
  • https://build.opensuse.org/package/show/openSUSE:Factory/wicked (v0.6.71)

[coveralls]

Coverage: 80.416% (+0.06%) from 80.356% when pulling ffcd364 on copy_specific_config into 24f3f87 on master.

[imobachgs]

Nothing critical, just a few comments about the overall approach because I feel it is influenced by the old code (which is neither good or bad).

[imobachgs]

In general, these classes encapsulate two different behaviors (which is fine):

• The logic to copy files to the target system (creating the directory, filtering out files, etc.).
• The list of files that you should copy for each case.

Perhaps, we would like to reuse part one only. Let's consider I only want to copy a single file, what about having an API for that (without subclassing)?

copier = Copier.new
copier.copy("/etc/hosts")
copier.copy("/etc/NetworkManager/system-connections", include: ["*.nmconnection"])

Now the Copier class looks more reusable to me. And you can use it even in your NetworkManager or Wicked classes:

class WickedCopier # or Writer or whatever
  def copy
    copier = Copier.new
    copier.copy("/etc/hosts")
    copier.copy("/etc/NetworkManager/system-connections", include: ["*.nmconnection"])
  end
end

WDYT?

[teclator]

Nothing critical, just a few comments about the overall approach because I feel it is influenced by the old code (which is neither good or bad).

Yes, in fact it is an part of the code was almost moved as it is.

[yast-bot]

✔️ Public Jenkins job #317 successfully finished
✔️ Created OBS submit request #1059539

[yast-bot]

✔️ Internal Jenkins job #212 successfully finished
✔️ Created IBS submit request #288536

[mchf]

Well ... already merged, but as i was asked for an opinion ... I've tested that, read through and it LGTM