Fix messed client #135
Merged
Fix messed client #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem is that even if clients acts like script, it is evaluated in global namespace and process is still alive, result is that it mess global namespace. In this particular case it breaks installation because it adds Yast::FileUtils to global namespace as ::FileUtils and when we require original FileUtils from ruby, then it collide and raise exception.
| @@ -1,60 +1,63 @@ | |||
| Yast.import "LanItems" | |||
| Yast.import "NetworkInterfaces" | |||
|
|
|||
| include Yast | |||
| #enclose client into own namespace to prevent messign global namespace | |||
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.