Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Guard secret attributes against leaking to the logs V2.0 #1360

Closed
wants to merge 1 commit into from

Conversation

shundhammer
Copy link
Contributor

@shundhammer shundhammer commented Mar 13, 2024

Problem

Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like inspect() are used.

Solution

Mark them as secret with secret_attr from YaST2::SecretAttributes.

Testing

Extended the unit tests.

Related PR

PR #1359 which used a #sanitized() method and a custom inspect() method, in effect doing the same manually that YaST::SecretAttributes does.

@coveralls
Copy link

coveralls commented Mar 13, 2024

Coverage Status

coverage: 80.784% (+0.003%) from 80.781%
when pulling e67b7c8 on huha-fix-pw-leak-2
into 2ac81c0 on master.

@shundhammer shundhammer changed the title Guard secret attributes against leaking Guard secret attributes against leaking to the logs V2.0 Mar 13, 2024
@shundhammer shundhammer changed the title Guard secret attributes against leaking to the logs V2.0 PoC: Guard secret attributes against leaking to the logs V2.0 Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants