New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced /etc/HOSTNAME using cross platform /etc/hostname #208
Conversation
Purpose is to be cross platform compatible
it was tested as DUD using build 436 |
Ops.add(fqhostname, "\n") | ||
) | ||
|
||
DNS.create_hostname_link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not simple create_hostname_link
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh ... copy & paste
fqhostname = install_inf_hostname | ||
end | ||
end | ||
if (Mode.installation || Mode.autoinst) && FileUtils.Exists("/etc/install.inf") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just idea now...why not use it for upgrade? I think we want in upgrade possibility to different network then on running system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrade mode is handled elsewhere. And yes, there is huge duplication of code ... but I need to investigate it more deeply.
In fact, this code is not accessed during upgrade.
LGTM |
Tested even in installed system. Thanks for review. |
Replaced /etc/HOSTNAME using cross platform /etc/hostname
bnc#858908