Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved help text in "global options" (bnc#892678) #264

Merged
merged 2 commits into from
Oct 10, 2014

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Oct 9, 2014

No description provided.

@schubi2
Copy link
Member

schubi2 commented Oct 9, 2014

How are new translation handled ? Please check this before we can merge with SLES12. Otherwise LGTM.

@lslezak
Copy link
Member

lslezak commented Oct 9, 2014

I guess this won't be translated, but it is in a help text which is not visible (until you click Help) so missing translation might be OK 😉 .

@ancorgs
Copy link
Contributor Author

ancorgs commented Oct 10, 2014

The bug, with the suggested solution of adding the string, was added to the list of bugs to be fixed for SLE12-Maint-Upd, so I assume they want the new string there despite the timing. @kobliha can you confirm?

@kobliha
Copy link
Member

kobliha commented Oct 10, 2014

It's OK to change texts in maintenance update

ancorgs added a commit that referenced this pull request Oct 10, 2014
Improved help text in "global options" (bnc#892678)
@ancorgs ancorgs merged commit 1ede967 into yast:SLE-12-GA Oct 10, 2014
@ancorgs ancorgs mentioned this pull request Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants