Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY: added IPv6 option (bnc#633310) #270

Merged
merged 1 commit into from
Jan 7, 2015
Merged

Conversation

mchf
Copy link
Member

@mchf mchf commented Nov 15, 2014

fate#316938

svn path=/trunk/network/; revision=62494

Conflicts:
	VERSION
	package/yast2-network.changes
	src/modules/Lan.ycp
@@ -255,6 +255,8 @@ define map ToAY (map settings) {

map ret = $[];
ret["managed"] = settings["managed"]:false;
if(haskey(settings, "ipv6"))
ret["ipv6"] = settings["ipv6"]:true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so by default is ipv6 enabled. Is it intention and is it documented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is port of already existing implementation. It behaves the same way like in OS > 11.4 and SLE12.

I'll explicitly ask for decision in the fate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the whole point of https://fate.suse.com/316938 is to make an option configurable which currently defaults to true already. If users want to disable it, they will explicitly set so in the profile. For others, nothing changes, right?

@jreidinger
Copy link
Member

if it is intention to have it by default to true, then LGTM

@mvidner
Copy link
Member

mvidner commented Jan 6, 2015

I have tested that it works (but only after a reboot, since is is implemented by blacklisting the module; that should be IMHO mentioned in the release notes).
LGTM.

mvidner added a commit that referenced this pull request Jan 7, 2015
AY: added IPv6 option (bnc#633310)
@mvidner mvidner merged commit 8044451 into yast:Code-11-SP4 Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants