Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform explicit device activation in case of ssh install. #432

Merged

Conversation

mchf
Copy link
Member

@mchf mchf commented Aug 24, 2016

bnc#993587

tested manually

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 46.348% when pulling b534957 on mchf:bnc993587-activate-ifaces-configured-in-installer into f847f9a on yast:master.

@@ -31,6 +31,7 @@
# Input and output routines.
require "yast"
require "network/confirm_virt_proposal"
require "network/wicked_handlers"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bcs I forgot to remove it when refactoring the patch ;-)

@mchf mchf force-pushed the bnc993587-activate-ifaces-configured-in-installer branch from b534957 to 56cf95a Compare August 25, 2016 14:36
@jreidinger
Copy link
Member

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 46.34% when pulling 56cf95a on mchf:bnc993587-activate-ifaces-configured-in-installer into f847f9a on yast:master.

@mchf
Copy link
Member Author

mchf commented Aug 25, 2016

Thanks for the review ... merging before you change your mind ;-)

@mchf mchf merged commit bb8074f into yast:master Aug 25, 2016
@mchf mchf deleted the bnc993587-activate-ifaces-configured-in-installer branch August 28, 2016 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants