-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sle15] AY setup written in first stage #520
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9c25d6a
Cleanup in DNS::Write - dropped dead code
mchf ef87aa3
Code cleanup: Splitted DNS::Write into smaller pieces
mchf 4bcc266
Enabled DNS::Write in AY's 1st stage
mchf be868cb
Made DNS::Write in 1st stage dependent on "second_stage" option
mchf dc0e9cc
Improved testsuite for configuring dns in AY's first stage
mchf d1a3ff5
happy rubocop
mchf d7b3d77
Splitted shared code into private methods in DNS module
mchf 40bdff0
Refactored NetworkAutoYast#configure_dns
mchf 77ee946
Added /etc/hosts config into NetworkAutoYast lib
mchf 4ffc055
Made Host#Write gui aware
mchf 8423096
Minor fixes + documentation
mchf dad7efe
Happy rubocop
mchf dd69fbb
Support for configuring routing in first stage only AY installation
mchf 1fc8484
Made Routing#Write gui aware
mchf 588c2a4
Support for writing NICs configuration in first stage
mchf 7a481a5
Use full Lan#Import in first stage only AY run
mchf 5b11294
Cleanup - removed unneccessary helpers from NetworkAutoYast module
mchf 77bfcd8
Documentation
mchf 766076d
Code cleanup
mchf f7eb359
Fixed typo in changelog
mchf a8d5ee9
Fixed typos, documentation
mchf 58bb702
Test Lan.FromAY
mvidner b9c5e1a
Updated changelog
mchf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ | |
|
||
|
||
Name: yast2-network | ||
Version: 3.3.2 | ||
Version: 3.3.3 | ||
Release: 0 | ||
BuildArch: noarch | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it would be more clear to replace this method by inlining
ay_current_profile.fetch("networking", {})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding
Host.Import
see bellowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my POV "networking" section is used quite often so it deserved own method as a shortcut.