New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUSEconfig for postfix and sendmail removed #59
Conversation
@@ -47,8 +47,8 @@ textdomain "network"; | |||
define boolean RunSuSEconfig() { | |||
y2milestone("Running SuSEconfig ..."); | |||
SCR::Execute(.target.bash, "/sbin/SuSEconfig --module apache 2>/dev/null"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even this one should be removed as suseconfig no longer exists in opensuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. I'm searching for replacement. If any.
I've checked apache2.changes in openSUSE Build Service > Projects > openSUSE:12.3 > apache2. It seems that SuSEconfig.apache2 was removed without replacement. a couple of years ago (2005). I'll ask apache2 maintainer to be sure. |
According apache2's README is not calling SuSEConfig needed anymore (since 2005 / SLES10), no replacement is mentioned here. So, I have removed it from yast. |
Fixed commit e16fbf9 according sendmail's spec file. |
Fix for sendmail confirmed by http://lists.opensuse.org/opensuse-bugs/2012-10/msg02913.html |
SCR::Execute(.target.bash, "/sbin/SuSEconfig --module apache 2>/dev/null"); | ||
SCR::Execute(.target.bash, "/sbin/SuSEconfig --module sendmail 2>/dev/null"); | ||
SCR::Execute(.target.bash, "/sbin/SuSEconfig --module postfix 2>/dev/null"); | ||
SCR::Execute(.target.bash, "/usr/lib/sendmail.d/update 2>/dev/null"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe link to documentation in comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice. But I don't know any documentation ;-)
otherwise LGTM |
Apache2's SuSEConfig module was removed sometime in 2005 (SLES10).
According changes in gdm package the script was dropped in 2010.
According i4l-base.changes it was replaced by: /etc/sysconfig/isdn/scripts/postprocess.isdn since OpenSUSE 12.3.
LGTM |
@@ -402,7 +402,7 @@ global define boolean Write(boolean start) ``{ | |||
// stage 6/13 | |||
plist = add(plist, _("Write providers")); | |||
// stage 7/13 | |||
plist = add(plist, _("Run SuSEconfig")); | |||
plist = add(plist, _("Update configuration...")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: without "..."
Yep, LGTM |
Based on #33.
Fixed according the comments.
Fixed testsuite and added changelog.