[WIP] Stop systemd socket associated services and ask for installing firewalld service definition #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalsrb could you also take a look? |
|
@teclator I can answer you any questions about Xvnc, vncmanager or novnc, if you have, but I am not familiar enough with the YaST code to review this, sorry. |
|
@michalsrb great, I will provide some screenshots and will summarize the changes and issues |
jreidinger
reviewed
Apr 23, 2018
| @@ -60,10 +60,32 @@ def main | |||
|
|
|||
| private | |||
|
|
|||
| # Convenience methof for obtaining a Y2Firewall::Firewalld instance | |||
jreidinger
reviewed
Apr 23, 2018
| package = Y2Remote::Remote::FIREWALL_SERVICES_PACKAGE | ||
| Yast::Package.InstallAllMsg( | ||
| [package], | ||
| _( |
There was a problem hiding this comment.
please add comment for translators what will be %s.
|
Close the PR by now as I do not plan to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card
In this PR we try to fix these issues:
For the first issue, we could ask for installing the package that ships the service definition
Once installed (tigervnc still needs to reload firewalld), we will be able to configure the firewall without having to run the client twice.
For the second issue, well, as @michalsrb already pointed on IRC it depends on whether we want to close ongoing connections or not.