Cleanup #636
Merged
Cleanup #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
requested changes
Jun 1, 2018
|
Apart of that, the methods that are left are only used by the inst_do_net_test.rb client, that is only used for examples https://github.com/search?p=1&q=org%3Ayast+do_net_test&type=Code What about droping it? |
|
dropping inst_do_net_test is the goal in this case, I'm still searching (and cherry-picking from my "refactoring" branch) for more code to remove -> less code to refactor ;-)) |
lslezak
approved these changes
Jun 20, 2018
package/yast2-network.changes
Outdated
| ------------------------------------------------------------------- | ||
| Wed Jun 20 07:24:24 UTC 2018 - mfilka@suse.com | ||
|
|
||
| - dropped useless and / or dead code |
There was a problem hiding this comment.
NP: dead code is usually useless, dropped dead code could be enough IMHO...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped some unreferenced methods, routing dialog definition into smaller parts