Expose the dhcp_ntp_servers method directly in Yast::Lan #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
force-pushed
the
dhcp_ntp_servers
branch
from
6b5cda9
to
428f1f0
Compare
dgdavid
reviewed
Nov 12, 2018
teclator
force-pushed
the
dhcp_ntp_servers
branch
from
929917c
to
2f806be
Compare
dgdavid
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method for retrieving
dhcp ntp serverswas initially added into [yast-caasp] repository(https://github.com/yast/yast-caasp) (see yast/yast-caasp#30) but it was also needed in yast-ntp-client for SLES installation.This PR adds that method into Yast::Lan following the DRY principle.