Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide icon with module #702

Merged
merged 4 commits into from
Nov 29, 2018
Merged

Provide icon with module #702

merged 4 commits into from
Nov 29, 2018

Conversation

noahadvs
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 25, 2018

Coverage Status

Coverage remained the same at 41.75% when pulling 609a7bf on noahadvs:fix-icons into afd0dea on yast:master.

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak
Copy link
Member

lslezak commented Nov 28, 2018

Ah, please rebase and resolve the conflicts, there has been another change merged in the meantime...

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit c133b01 into yast:master Nov 29, 2018
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #30 successfully finished
✔️ Created OBS submit request #652549

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #29 successfully finished
✔️ Created IBS submit request #178723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants