Builder improvements #823
Builder improvements #823
Conversation
|
|
||
| def name_valid_characters | ||
| Yast::NetworkInterfaces.ValidCharsIfcfg | ||
| end |
There was a problem hiding this comment.
seeing all those method, maybe having object for name makes sense?
There was a problem hiding this comment.
I think that this method is not correct. It is used only at one place for validating ifcfg name but it can validate even characters which are not allowed in ifcfg (respectively network device) names - see https://github.com/yast/yast-yast2/blob/master/library/types/src/modules/String.rb#L591 and https://github.com/yast/yast-yast2/blob/master/library/types/src/modules/String.rb#L42
Correct validator is a few lines above - valid_name?
There was a problem hiding this comment.
so is it bug in ValidCharsIfcfg? I just need to get array with chars that is allowed.
| target_driver = driver | ||
| if target_driver.empty? | ||
| target_driver = Yast::Ops.get_string(Yast::LanItems.getCurrentItem, ["hwinfo", "module"], "") | ||
| end |
There was a problem hiding this comment.
we have Hwinfo class so we can relax dependency on LanItems here
Hwinfo.new(name).module
(module method is currently missing in the Hwinfo class but it is very easy to add)
No description provided.