Consistent delete/rename #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
approved these changes
Oct 9, 2019
src/lib/y2network/config.rb
Outdated
| @@ -205,6 +210,54 @@ def configured_interface?(iface_name) | |||
| !connections.by_interface(iface_name).empty? | |||
| end | |||
|
|
|||
| # @note does not work recursivelly. So for delete it needs to be called for all modified vlans. | |||
| connections.by_interface(old_name).each { |c| c.interface = new_name } | ||
| connections.by_interface(old_name).each do |connection| | ||
| connection.interface = new_name | ||
| rename_dependencies(old_name, new_name, connection) |
There was a problem hiding this comment.
np: Perhaps you could omit the old_name or the new_name as it is contained in the connection instance.
There was a problem hiding this comment.
where it is contained? I only found it in interface class, but not in connection one.
There was a problem hiding this comment.
Is not connection.interface?
There was a problem hiding this comment.
connection.interface is only the new name ( it is string ). So this way it is more explicit for me.
imobachgs
approved these changes
Oct 9, 2019
|
✔️ Public Jenkins job #89 successfully finished |
|
✔️ Internal Jenkins job #19 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/9q8UEvBD/1326-5-network-handle-properly-removal-and-rename-of-interfaces
https://bugzilla.suse.com/show_bug.cgi?id=1153460