Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable compiling, testing, packaging from the WC (bnc#790490) #5

Merged
merged 4 commits into from
Dec 17, 2012

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Dec 14, 2012

groundwork for SP3 features

@mvidner
Copy link
Member Author

mvidner commented Dec 14, 2012

BTW for full benefits this also needs a companion change in devtools (already merged) but it is a packaging-time dependency, not build- or run-time, so it is not expressed in the spec file.

@jsuchome
Copy link
Contributor

Is it actually needed for SP3 feature? Shouldn't it be better to leave changes like this for Factory/SLE12?

@kobliha
Copy link
Member

kobliha commented Dec 14, 2012

As we will have to maintain the module for a few more years, every forward-looking approach is good IMO.

@mvidner
Copy link
Member Author

mvidner commented Dec 14, 2012

  1. Needed? No-but-yes. 2) For a development branch only? No.

  2. Benefits vs. costs and risks: enabling easier testing is important for a maintenance branch where we want to add tests to avoid regressions. (Note that I even target SP2, not only SP3.) That outweighs the cost of restructuring the git tree.
    Concerning the risks, I see them as low: the RPM tree stays the same, as long as I made no error in Makefiles. I have now checked the file lists of the resulting RPMs to be the same.
    So being useful and low-risk qualifies it for here.

  3. The feature would be possible without it, but I've developed it on the new tree already. (It was helpful in adding these tests.)

@mchf
Copy link
Member

mchf commented Dec 14, 2012

Definitely needed and useful. Git is able to track changes even when a file is renamed, so I don't see any problem.

kobliha added a commit that referenced this pull request Dec 17, 2012
enable compiling, testing, packaging from the WC (bnc#790490)
@kobliha kobliha merged commit 689ebdc into yast:Code-11-SP2 Dec 17, 2012
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants